Skip to content

chore: Cleanup hostNamesConfig.js#25543

Merged
john-bodley merged 1 commit intomasterfrom
john-bodley--cleanup-host-names-config
Oct 17, 2023
Merged

chore: Cleanup hostNamesConfig.js#25543
john-bodley merged 1 commit intomasterfrom
john-bodley--cleanup-host-names-config

Conversation

@john-bodley
Copy link
Copy Markdown
Member

@john-bodley john-bodley commented Oct 5, 2023

SUMMARY

Flexing my very limited frontend knowledge to cleanup checking for whether bootstrapData.common.conf.SUPERSET_WEBSERVER_DOMAINS is defined.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley requested a review from justinpark October 5, 2023 20:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #25543 (df5beae) into master (0c40bea) will increase coverage by 0.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #25543      +/-   ##
==========================================
+ Coverage   68.51%   69.13%   +0.61%     
==========================================
  Files        1915     1915              
  Lines       75100    75100              
  Branches     8314     8314              
==========================================
+ Hits        51455    51920     +465     
+ Misses      21503    21038     -465     
  Partials     2142     2142
Flag Coverage Δ
hive 53.68% <ø> (ø)
javascript 56.32% <100.00%> (+<0.01%) ⬆️
mysql 78.34% <ø> (?)
postgres 78.44% <ø> (?)
presto 53.63% <ø> (ø)
python 82.86% <ø> (+1.27%) ⬆️
sqlite 77.08% <ø> (ø)
unit 55.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
superset-frontend/src/utils/hostNamesConfig.js 73.33% <100.00%> (ø)

... and 38 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley merged commit 32e37d8 into master Oct 17, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@john-bodley
chore: Cleanup hostNamesConfig.js (apache#25543)
2062ad3
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 First shipped in 3.1.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the john-bodley--cleanup-host-names-config branch March 26, 2024 17:56
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@john-bodley
chore: Cleanup hostNamesConfig.js (apache#25543)
c6f653a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinpark justinpark justinpark approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0 First shipped in 3.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@john-bodley @justinpark @mistercrunch